Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]关于lownodeload plugin的疑问 #1854

Closed
bogo-y opened this issue Jan 18, 2024 · 1 comment · Fixed by #1858
Closed

[BUG]关于lownodeload plugin的疑问 #1854

bogo-y opened this issue Jan 18, 2024 · 1 comment · Fixed by #1858
Labels
area/koord-descheduler bug Something isn't working

Comments

@bogo-y
Copy link
Contributor

bogo-y commented Jan 18, 2024

What happened:
在重调度插件的processOneNodePool函数中，有把节点标记为Normal或AbNormal的逻辑，我对其中的tryMarkNodesAsNormal有些困惑。我的理解是，调用evictPodsFromSourceNodes时传入的是abnormalNodes，tryMarkNodesAsNormal的作用应该是为刚刚执行了驱逐的abnormalNodes调用一次onNormality，当前将sourceNodes作为参数应该是一个Bug，这会导致任何一次驱逐逻辑之后所有资源利用率高于阈值的节点的ConsecutiveAbnormalities被清零。
@bogo-y bogo-y added the kind/question Support request or question relating to Koordinator label Jan 18, 2024
@eahydra
Copy link
Member

eahydra commented Jan 19, 2024

感谢反馈，这确实是个bug，应该是要处理 abnormalNodes。有兴趣修复下么？

@eahydra eahydra added bug Something isn't working area/koord-descheduler and removed kind/question Support request or question relating to Koordinator labels Jan 19, 2024
@eahydra eahydra changed the title [question]关于lownodeload plugin的疑问 [BUG]关于lownodeload plugin的疑问 Jan 19, 2024
@bogo-y bogo-y mentioned this issue Jan 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/koord-descheduler bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

descheduler: fix bug of nodeAnomalyDetector in LowNodeLoad plugin
2 participants
@eahydra @bogo-y