Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] koordlet support memoryEvictLowerPercent field in NodeSLO #85

Closed
eahydra opened this issue Apr 19, 2022 · 3 comments · Fixed by #132
Closed

[feature request] koordlet support memoryEvictLowerPercent field in NodeSLO #85

eahydra opened this issue Apr 19, 2022 · 3 comments · Fixed by #132
Assignees
@jasonliu747
Labels
area/koordlet
Milestone
v0.4

Comments

@eahydra
Copy link
Member

eahydra commented Apr 19, 2022 •
edited
Loading

What happened:

memoryEvictLowerPercent is defined in NodeSLO, but koordlet does not support it.

What you expected to happen:

Expect koordlet supports memoryEvictLowerPercent in NodeSLO

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • App version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Others:
@eahydra
Copy link
Member Author

eahydra commented Apr 19, 2022

/assign @jasonliu747

@eahydra eahydra changed the title [BUG] Setting memoryEvictLowerPercent in NodeSLO via slo-controller-config is not supported [BUG] koordlet does not support memoryEvictLowerPercent field in NodeSLO Apr 20, 2022
@jasonliu747
Copy link
Member

@eahydra
image

@eahydra eahydra changed the title [BUG] koordlet does not support memoryEvictLowerPercent field in NodeSLO [feature request] koordlet does not support memoryEvictLowerPercent field in NodeSLO Apr 21, 2022
@eahydra eahydra changed the title [feature request] koordlet does not support memoryEvictLowerPercent field in NodeSLO [feature request] koordlet support memoryEvictLowerPercent field in NodeSLO Apr 21, 2022
@jasonliu747
Copy link
Member

/area koordlet

@jasonliu747 jasonliu747 added this to the v0.4 milestone May 7, 2022
@shinytang6 shinytang6 mentioned this issue May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonliu747 jasonliu747

Labels
area/koordlet
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

feat(koordlet): support memoryEvictLowerPercent in memory evict shinytang6/koordinator
2 participants
@eahydra @jasonliu747