Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The description of throttlingPercent in the documentation is incorrect #182

Closed
j4ckstraw opened this issue Apr 25, 2024 · 5 comments
Closed

[BUG] The description of throttlingPercent in the documentation is incorrect #182

j4ckstraw opened this issue Apr 25, 2024 · 5 comments
Assignees
@j4ckstraw
Labels
documentation Improvements or additions to documentation

Comments

@j4ckstraw
Copy link

What happened:
文档中关于throttlingPercent的描述没有更新，和代码实现不一致。
image

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • App version:
  • Kubernetes version (use kubectl version):
  • Install details (e.g. helm install args):
  • Node environment (for koordlet/runtime-proxy issue):
    • Containerd/Docker version:
    • OS version:
    • Kernal version:
    • Cgroup driver: cgroupfs/systemd
  • Others:
@saintube
Copy link
Member

Nice catch. The memory.high calculation is upgraded following the K8S 1.27 (see koordinator-sh/koordinator#1455), so the documentation is outdated.

@saintube saintube added the documentation Improvements or additions to documentation label Apr 28, 2024
@zwzhang0107
Copy link
Contributor

it will be great if you can update the website

@jasonliu747
Copy link
Member

/assign @j4ckstraw
https://github.com/koordinator-sh/website

@saintube saintube mentioned this issue Jun 3, 2024
Closed
@saintube
Copy link
Member

saintube commented Jun 3, 2024

To be fixed by #180

@saintube saintube transferred this issue from koordinator-sh/koordinator Jun 12, 2024
@saintube
Copy link
Member

Should be fixed by #181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j4ckstraw j4ckstraw

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

user manuals: update memory.high formula saintube/website
4 participants
@j4ckstraw @saintube @jasonliu747 @zwzhang0107