[Android] add step-by-step adjustment on frontlight dialog and a way to switch back to system defaults

[dcruzbosco]

• KOReader version: 2020.10.1
• Device: MiPad 1

Issue

Since version 2020.09, accessing the Frontlight dialog opens native Android brightness popup.
I am interested in knowing how I can go back to the old in-app Frontlight dialog (widget) that allows step-by-step brightness adjustment.
Is there a setting or property to be added in settings.lua for example, that would allow me to switch back to the old brightness adjustment popup?

[pazos]

Nope, you can't. The good old frontlight widget is not available for a very good reason: it was a PITA to work with and didn't support per device overrides.

step-by-step brightness adjustment.

This is doable with the android dialog too. But needs to be done :)

edit: I mean add a couple of +/- buttons to https://github.com/koreader/android-luajit-launcher/blob/master/app/src/org/koreader/launcher/MainActivity.kt#L261-L317

[dcruzbosco]

Thanks! This helps a lot!

[pazos]

@dcruzbosco: I'm going to update the ticket. Patches welcome!

[pazos]

Including, from koreader/koreader#11837

The Moon Reader app solves this issue by having a toggle checkbox next to the slider that enables/disables forced brightness override. Might be a good solution beyond the workaround of just not touching the in-app brightness slider.

We can do the same for devices using the generic driver. Actually in that driver 0 means system defaults.

Expected behaviour:

Checking the box should disable the widget slider.
Unchecking the box should enable the widget slider (and adjust to current brightness)
Gestures should uncheck the box if checked.