Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for a bunch of rockchip devices #483

Merged
merged 1 commit into from
May 19, 2024

Conversation

hugleo
Copy link
Contributor

@hugleo hugleo commented May 19, 2024

Device info:
Manufacturer: haoqing
Brand: haoqing
Model: m6
Device: m6
Product: rk3566_eink
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: haoqing
Brand: haoqing
Model: m7
Device: m7
Product: rk3566_eink
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: rockchip
Brand: rockchip
Model: moaanmix7
Device: rk3566_eink
Product: moaan
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: rockchip
Brand: rockchip
Model: inkpalmplus
Device: rk3566_eink
Product: moaan
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566


This change is Reviewable

Device info:
Manufacturer: haoqing
Brand: haoqing
Model: m6
Device: m6
Product: rk3566_eink
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: haoqing
Brand: haoqing
Model: m7
Device: m7
Product: rk3566_eink
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: rockchip
Brand: rockchip
Model: moaanmix7
Device: rk3566_eink
Product: moaan
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566

Device info:
Manufacturer: rockchip
Brand: rockchip
Model: inkpalmplus
Device: rk3566_eink
Product: moaan
Hardware: rk30board
Platform: rk356x

Working EPD Driver: RK3566
@pazos pazos merged commit 2242cf2 into koreader:master May 19, 2024
1 check passed
@hugleo hugleo deleted the bunch-rockchip branch May 30, 2024 13:20
@Bluemoondragon07
Copy link

Are these changes in effect for recent nightlies of KOreader? The Meebook M7 is still registered as an unsupported device in the most recent nightly release.

@benoit-pierre
Copy link
Contributor

Yes, since v2024.04-206-gb7fc048bb.

@hugleo
Copy link
Contributor Author

hugleo commented Nov 1, 2024

@Bluemoondragon07, can you run the KOReader eink test tool to confirm your device?
Follow instructions here: koreader/koreader#8482

@Bluemoondragon07
Copy link

20241101_190544

The Rockchip rk3566 works when I test it. For some reason, the device just doesn't register as supported. I will see if downloading the last stable release, 2024.07, fixes anything.

@Bluemoondragon07
Copy link

Uninstalling and reinstalling 2024.07 didn't do the trick, unfortunately.

@benoit-pierre
Copy link
Contributor

Could it be some sort of trailing whitespace in some fields that would trip one or more of the string equality tests?

hugleo added a commit to hugleo/android-luajit-launcher that referenced this pull request Nov 2, 2024
@Bluemoondragon07
Copy link

So, with the latest nightly, the Meebook M7 now shows up as supported, but the full screen refresh function does not work using gestures. Setting the page refresh in e-ink settings to refresh every page, nothing happens.

20241114_151455.jpg

So, still can't trigger refreshes yet, but it's showing up as supported now.

Also, I tried in both regal/normal mode and A2/fast mode.

@hugleo
Copy link
Contributor Author

hugleo commented Nov 14, 2024

So, with the latest nightly, the Meebook M7 now shows up as supported, but the full screen refresh function does not work using gestures. Setting the page refresh in e-ink settings to refresh every page, nothing happens.

20241114_151455.jpg

So, still can't trigger refreshes yet, but it's showing up as supported now.

Also, I tried in both regal/normal mode and A2/fast mode.

in eink-test is Working EPD Driver RK3566 or another one?

@Bluemoondragon07
Copy link

@hugleo Yes, in compatibility test Rockchip Rk3566 triggers a full refresh in all refresh modes.

@Bluemoondragon07
Copy link

20241114_151225.mp4

@hugleo
Copy link
Contributor Author

hugleo commented Nov 15, 2024

@pazos One of those hard cases that works on E Ink but not KOReader. Any advice?

@Bluemoondragon07
Copy link

It might have something to do with KOreader not using typical Android elements? I can't get anything in KOreader, except in compatibility test, to trigger a refresh, even with native device settings. In most apps, such as Moon Reader, if I have the device refresh rate set to 1, then every tap on an Android element or app event triggered by a physical button press causes a refresh.

When I go into compatibility test, I know it must be using Android elements, because any button I press there will follow the device refresh rate settings. Of course, pressing the Rk3566 test will make it refresh every time anyway regardless of device settings. But with that refresh-rate-of-1 setting, any of those buttons trigger a refresh if I tap on them.

But as soon as I exit that compatibility test in KOreader, there is nothing within the app that can cause a refresh. I can only refresh it manually through the OS from there.

@Frenzie
Copy link
Member

Frenzie commented Nov 15, 2024

But with that refresh-rate-of-1 setting, any of those buttons trigger a refresh if I tap on them.

That's a very irrelevant test then. ;-) Try it with the system's refresh setting set to something significantly higher than 1.

@Bluemoondragon07
Copy link

@Frenzie my tests have been with different refresh rates, I was just giving a specific example of how the UI in compatibility test reacts to device system refresh rate but the rest of the app does not. The RK3566 test always refreshes the screen, regardless of refresh rate or even refresh mode. It's just that I notice other buttons in the test can trigger system refreshes because they are registered as real Android buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants