rework DeviceInfo.kt #526
Merged
rework DeviceInfo.kt #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to #432, the generic controller is the right choice for the Onyx Palma. |
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
from
e788cd9
to
ba80e04
Compare
Frenzie
approved these changes
Nov 4, 2024
Yes, lightsMap[LightsDevice.ONYX_PALMA] = ONYX_PALMA was added by mistake |
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
from
ba80e04
to
bc2e5a9
Compare
hugleo
reviewed
Nov 8, 2024
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
from
bc2e5a9
to
51f357e
Compare
pazos
reviewed
Nov 8, 2024
pazos
approved these changes
Nov 8, 2024
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
3 times, most recently
from
99e005f
to
e828a12
Compare
hugleo
reviewed
Nov 10, 2024
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
2 times, most recently
from
d96d77e
to
15233ac
Compare
hugleo
approved these changes
Nov 10, 2024
Reduce duplication to make it easier to maintain. Fix the following issues: - possible problem with `EINK` value on `TOLINO_EPOS3` devices (since both `TOLINO` and `TOLINO_EPOS3` booleans would be set) - `EINK` was never set to `EinkDevice.TOLINO_VISION6`, but checked in `device/EPDFactory.kt` - same with `HANVON_960` & `HYREAD_MINI6` - `LIGHTS` was never set to `LightsDevice.ONYX_NOTE_PRO`, but checked in `device/LightsFactory.kt` - `LIGHTS` could be set to `LightsDevice.ONYX_PALMA`, but was never checked in `device/LightsFactory.kt` Note: also drop device properties: `is_boyue` (unused) & `is_tolino` (only used to add direction pad mappings, details were added to the relevant wiki page instead), and no hardware rotation quirk (which was an incomplete emulator only workaround).
benoit-pierre
force-pushed
the
pr/DeviceInfo.kt_rework
branch
from
15233ac
to
f8c12ad
Compare
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 13, 2024
benoit-pierre
added a commit
to benoit-pierre/android-luajit-launcher
that referenced
this pull request
Nov 21, 2024
Regression from koreader#526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce duplication to make it easier to maintain.
Fix the following issues:
EINKvalue onTOLINO_EPOS3devices (since bothTOLINOandTOLINO_EPOS3booleans would be set)EINKwas never set toEinkDevice.TOLINO_VISION6, but checked indevice/EPDFactory.ktHANVON_960&HYREAD_MINI6LIGHTSwas never set toLightsDevice.ONYX_NOTE_PRO, but checked indevice/LightsFactory.ktStill not fixed:
-LIGTScould be set toLightsDevice.ONYX_PALMA, but was never checked indevice/LightsFactory.ktAlso address #483 (comment), will conflict with #525.
This change is