Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven publishing #6

Closed
Doomsdayrs opened this issue Jun 17, 2023 · 10 comments
Closed

Maven publishing #6

Doomsdayrs opened this issue Jun 17, 2023 · 10 comments

Comments

@Doomsdayrs
Copy link

The maven-publish plugin is missing, meaning this library cannot be easy installed.

@soywiz
Copy link
Member

soywiz commented Jun 17, 2023

What's your specific use-case for it?

This korge-luak project is exposed via kproject instead of maven-publish.
You can use it by adding a few lines of code to the settings.gradle.kts and build.gradle.kts as explained here: https://docs.korge.org/kproject/#usage

Could you try to use kproject instead of maven?

@Doomsdayrs
Copy link
Author

Doomsdayrs commented Jun 17, 2023

What's your specific use-case for it?

https://shosetsu.app/ uses Lua extensions, currently relying on the ancient luaj libraries. I want to swap to LuaK to enable cross platform support.

Could you try to use kproject instead of maven?

Why would I use a non-standard implementation that only offers me libraries that are present under korlibs (which I do have a use for)?

@soywiz
Copy link
Member

soywiz commented Jun 18, 2023

I see. Thanks for the explanation. This specific repository is not published to central but can be consumed via kproject.

If you want to use maven pre-compiled artifacts or maven for this specific project, you can use an old version that was published to central before here:
https://central.sonatype.com/artifact/com.soywiz.korlibs.luak/luak/4.0.0-alpha-2
You can also fork it or include a git submodule and publish to maven yourself too.

@Doomsdayrs
Copy link
Author

This specific repository is not published to central but can be consumed via kpr

That is not quite what I want, enabling the maven-publish plugin allows users to install it locally or on their own maven instances.

I do not think this would be difficult to implement for you, as you know your own software stack. Allowing developers to use the library both via maven and kproject.

@soywiz
Copy link
Member

soywiz commented Jun 19, 2023

Are you proposing to add the maven-publish plugin to the root build.gradle.kts that includes the example+library? Or to the library itself? The library doesn't include a build.gradle file itself since it is generated by kproject. I could apply that plugin in kproject, but kproject would still be required.

@JochenGuckSnk
Copy link
Contributor

What is the blocker which prevents the general publikation to a maven repo? Im interested in just having the up to date implementation via maven.

@DersWasTaken
Copy link
Contributor

Maven Publishing is not up to date on Maven Central. Is it possible to update so I can use the library standalone?

@soywiz
Copy link
Member

soywiz commented Dec 17, 2023

This repo accepts PRs. But in any case, the Add Maven Publish PR wasn't there so it could be already used with jitpack? https://jitpack.io/

Edit: I'm closing it. Central was published before because the infrastructure was there for that, but now this is intended to be used either with kproject or jitpack. It is still viable to make forks and publish to central, or make a PR adding support for publishing to central.

@soywiz soywiz closed this as completed Dec 17, 2023
@DersWasTaken
Copy link
Contributor

Jitpack also does not build, I should have mentioned that. My apologies

@DersWasTaken
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants