Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ac: links broken when underscore in link text #394

Closed
Skeeve opened this issue Dec 1, 2023 · 0 comments · Fixed by #473
Closed

ac: links broken when underscore in link text #394

Skeeve opened this issue Dec 1, 2023 · 0 comments · Fixed by #473
Labels

Comments

@Skeeve
Copy link
Contributor

Skeeve commented Dec 1, 2023

What happened?

# test

## completely broken
[test_link](ac:)

## partly broken
[test_link](ac:test_link)
[test_link](<ac:test_link>)

Will produce:

<h1 id="test">test</h1>
<h2 id="completely-broken">completely broken</h2>
<p><ac:link><ri:page ri:content-title="test_"/><ac:plain-text-link-body><![CDATA[test_]]></ac:plain-text-link-body></ac:link></p>
<h2 id="partly-broken">partly broken</h2>
<p><ac:link><ri:page ri:content-title="test_link"/><ac:plain-text-link-body><![CDATA[test_]]></ac:plain-text-link-body></ac:link>
<ac:link><ri:page ri:content-title="test_link"/><ac:plain-text-link-body><![CDATA[test_]]></ac:plain-text-link-body></ac:link></p>

What did you expect to happen?

I expected the link text, as well as the link to read "test_link".

Instead, in the first version, everything after the "_" is cut off.

In the second and third version, the link is okay, but the link text itself is broken as before.

How can we reproduce the behavior you experienced?
Steps to reproduce the behavior:

  1. create a file with the content above
  2. run mark --compile-only --h1_title -f FILENAME
  3. observe the issue.

Information (please complete the following information)

  • Mark Version (mark --version): 9.10.1
  • Mark Parameters: --compile-only --h1_title
  • Confluence Hosting: not relevant
  • Confluence Version: not relevant
  • Environment specific Information: Mac OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant