Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow space home update and its children pages #101

Merged
merged 5 commits into from
Aug 23, 2021
Merged

allow space home update and its children pages #101

merged 5 commits into from
Aug 23, 2021

Conversation

eitchugo
Copy link
Contributor

@eitchugo eitchugo commented Aug 8, 2021

This patch allows editing a Space Home Page as defined in Confluence Space Settings. It also allows to create/update the home page's direct children using a parent meta:

<!-- Parent: Space Home -->

If a page isn't a direct child of the space homepage, the above parent should not be present.

Notice that this will also query confluence API on /space/{spaceKey} to check which page is defined as the Space Home. This happens on every run.

Should resolve Issue #88

Copy link
Owner

@kovetskiy kovetskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, but we still need to fix a few code style problems. Thank you for your contribution!

pkg/mark/mark.go Outdated Show resolved Hide resolved
pkg/confluence/api.go Outdated Show resolved Hide resolved
pkg/mark/mark.go Outdated Show resolved Hide resolved
@kovetskiy
Copy link
Owner

You can also see that you've committed with (probably) your work email, do you want to force push your commit with your GitHub's email? GitHub didn't recognize your email and didn't attach your commit to your profile.

https://github.com/kovetskiy/mark/commit/6aa37507a3e79ce5cc5901f7414b4f5f8b5e7381.patch

@eitchugo
Copy link
Contributor Author

@kovetskiy that's OK, I don't mind not having my github email on the commits, have it your way :D

Issues should have been resolved, let me know if there's anything else I could do

pkg/mark/ancestry.go Outdated Show resolved Hide resolved
pkg/mark/mark.go Outdated Show resolved Hide resolved
@kovetskiy kovetskiy merged commit 97313e5 into kovetskiy:master Aug 23, 2021
@kovetskiy
Copy link
Owner

Thanks!

@eitchugo eitchugo deleted the root-article-fix branch September 16, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants