-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow space home update and its children pages #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, but we still need to fix a few code style problems. Thank you for your contribution!
You can also see that you've committed with (probably) your work email, do you want to force push your commit with your GitHub's email? GitHub didn't recognize your email and didn't attach your commit to your profile. https://github.com/kovetskiy/mark/commit/6aa37507a3e79ce5cc5901f7414b4f5f8b5e7381.patch |
@kovetskiy that's OK, I don't mind not having my github email on the commits, have it your way :D Issues should have been resolved, let me know if there's anything else I could do |
Thanks! |
This patch allows editing a Space Home Page as defined in Confluence Space Settings. It also allows to create/update the home page's direct children using a parent meta:
If a page isn't a direct child of the space homepage, the above parent should not be present.
Notice that this will also query confluence API on
/space/{spaceKey}
to check which page is defined as the Space Home. This happens on every run.Should resolve Issue #88