Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Refactor from __init__ signature updates model names. #29

Closed
dmontagu opened this issue Aug 13, 2019 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@dmontagu
Copy link
Contributor

Feature Request

In response to #16, it is now the case that refactors for class attributes result in a dialog offering the ability to change the variable names in __init__ calls. This is extremely useful, and it is now possible in theory to do safe __init__-call refactors by just modifying the attribute name on the class.

However, it would still be nice to be able to perform the refactor operation directly from inside the __init__ call, and have it update the class variable name and other __init__ call keyword arguments.

This is a substantially lower priority since you can accomplish this now by just jumping to the class definition first and refactoring there, but I wanted to create an issue for tracking.

@koxudaxi
Copy link
Owner

@dmontagu
I have implement you want the features.
Would you please check the latest version on GitHub release page?
There is the plugin in JetBrains repo, but the version is a bit old.
The plugin is uploaded to JetBrains repo from CI.
However, Jetbrains member has to approve the plugin which to publish every version.
They spend two days for checking it :(

@dmontagu
Copy link
Contributor Author

dmontagu commented Aug 14, 2019

Confirmed it works for me. Amazing 🙌🎉🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants