Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types of methods and functions #123

Merged
merged 3 commits into from
May 5, 2020
Merged

Fix types of methods and functions #123

merged 3 commits into from
May 5, 2020

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented May 3, 2020

This PR fixes types of methods and functions.
The plugin copy py files into stub dir as stubs files (a.k.a *.pyi).

Related Issues

#122

@koxudaxi koxudaxi changed the title [WIP] delete untyped stubs to fix types of methods and functions [WIP] Fix types of methods and functions May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #123 into master will decrease coverage by 0.79%.
The diff coverage is 35.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
- Coverage     70.47%   69.68%   -0.80%     
- Complexity      136      138       +2     
============================================
  Files            14       14              
  Lines           911      940      +29     
  Branches        272      281       +9     
============================================
+ Hits            642      655      +13     
- Misses          134      146      +12     
- Partials        135      139       +4     
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticInitializer.kt 67.22% <35.29%> (-7.22%) 18.00 <1.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3336f6f...fdebc3d. Read the comment docs.

@koxudaxi
Copy link
Owner Author

koxudaxi commented May 4, 2020

  • TODO unittest

@koxudaxi koxudaxi changed the title [WIP] Fix types of methods and functions Fix types of methods and functions May 5, 2020
@koxudaxi koxudaxi merged commit 677c8f6 into master May 5, 2020
@koxudaxi koxudaxi deleted the delete_untyped_stubs branch May 5, 2020 15:09
@koxudaxi
Copy link
Owner Author

koxudaxi commented May 5, 2020

I will improve the class for the unittest.
And, I will create other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant