Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling pydantic version #286

Merged
merged 2 commits into from
May 3, 2021
Merged

Improve handling pydantic version #286

merged 2 commits into from
May 3, 2021

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented May 2, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2021 •
edited
Loading

Codecov Report

Merging #286 (59fcf10) into master (e34c388) will increase coverage by 0.26%.
The diff coverage is 67.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
+ Coverage     71.05%   71.32%   +0.26%     
- Complexity      230      240      +10     
============================================
  Files            22       23       +1     
  Lines          1389     1402      +13     
  Branches        443      443              
============================================
+ Hits            987     1000      +13     
  Misses          153      153              
  Partials        249      249
Flag Coverage Δ Complexity Δ
unittests 71.32% <67.56%> (+0.26%) 240.00 <10.00> (+10.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rc/com/koxudaxi/pydantic/PydanticVersionService.kt 54.54% <54.54%> (ø) 9.00 <9.00> (?)
...oxudaxi/pydantic/PydanticPackageManagerListener.kt 69.23% <77.77%> (+26.37%) 3.00 <1.00> (+1.00)
src/com/koxudaxi/pydantic/Pydantic.kt 74.16% <100.00%> (+2.40%) 0.00 <0.00> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 80.74% <100.00%> (ø) 1.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 77.86% <100.00%> (ø) 2.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.62% <100.00%> (ø) 104.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fe821...59fcf10. Read the comment docs.

@koxudaxi koxudaxi merged commit a2bb9cd into master May 3, 2021
@koxudaxi koxudaxi deleted the improve_handling_pydantic_version branch May 3, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koxudaxi