Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GenericModel #289

Merged
merged 6 commits into from
May 9, 2021
Merged

Support GenericModel #289

merged 6 commits into from
May 9, 2021

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented May 5, 2021

Related Issues

#275

@codecov
Copy link

codecov bot commented May 5, 2021 •
edited
Loading

Codecov Report

Merging #289 (3d6c2c9) into master (f8956bb) will increase coverage by 0.54%.
The diff coverage is 76.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     72.32%   72.86%   +0.54%     
- Complexity      240      274      +34     
============================================
  Files            23       23              
  Lines          1474     1618     +144     
  Branches        449      487      +38     
============================================
+ Hits           1066     1179     +113     
- Misses          157      166       +9     
- Partials        251      273      +22
Flag Coverage Δ Complexity Δ
unittests 72.86% <76.98%> (+0.54%) 274.00 <47.00> (+34.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...koxudaxi/pydantic/PydanticTypeCheckerInspection.kt 87.75% <0.00%> (ø) 3.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 77.20% <50.00%> (ø) 2.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.17% <70.54%> (-0.45%) 137.00 <39.00> (+33.00) ⬇️
...m/koxudaxi/pydantic/PydanticFieldSearchExecutor.kt 68.42% <78.26%> (-0.33%) 21.00 <8.00> (ø)
src/com/koxudaxi/pydantic/Pydantic.kt 74.80% <84.21%> (+0.41%) 0.00 <0.00> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 85.04% <88.23%> (+1.19%) 1.00 <0.00> (ø)
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 90.74% <92.30%> (+0.35%) 11.00 <0.00> (ø)
...koxudaxi/pydantic/PydanticDataclassTypeProvider.kt 73.52% <100.00%> (+2.94%) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28836a...3d6c2c9. Read the comment docs.

@koxudaxi koxudaxi marked this pull request as draft May 5, 2021 17:16
@koxudaxi koxudaxi marked this pull request as ready for review May 9, 2021 08:48
@koxudaxi koxudaxi merged commit a72ca6c into master May 9, 2021
@koxudaxi koxudaxi deleted the support_generic_model branch May 9, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koxudaxi