Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Field for v1 #73

Merged
merged 3 commits into from
Sep 22, 2019
Merged

support Field for v1 #73

merged 3 commits into from
Sep 22, 2019

Conversation

koxudaxi
Copy link
Owner

The PR supports Field for pydantic v1
Also, the PR has a feature to detect pydantic version.

Related Issues

pydantic/pydantic#577

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #73 into master will decrease coverage by 0.14%.
The diff coverage is 73.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     77.83%   77.69%   -0.15%     
- Complexity       80       83       +3     
============================================
  Files             7        7              
  Lines           361      399      +38     
  Branches        129      140      +11     
============================================
+ Hits            281      310      +29     
- Misses           25       27       +2     
- Partials         55       62       +7
Impacted Files Coverage Δ Complexity Δ
...koxudaxi/pydantic/PydanticCompletionContributor.kt 91.66% <100%> (+0.1%) 1 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 71.42% <66.66%> (-0.8%) 0 <0> (ø)
src/com/koxudaxi/pydantic/PydanticInspection.kt 78.57% <75%> (+0.79%) 2 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 68.8% <78.26%> (+1.81%) 42 <4> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c769603...bb65d7b. Read the comment docs.

@koxudaxi koxudaxi merged commit e96f56d into master Sep 22, 2019
@koxudaxi koxudaxi deleted the support_field_for_v1 branch September 22, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant