Improve to insert validate methods #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
- Coverage 77.69% 70.93% -6.76%
Complexity 83 83
============================================
Files 7 8 +1
Lines 399 437 +38
Branches 140 152 +12
============================================
Hits 310 310
- Misses 27 65 +38
Partials 62 62
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR improves to insert validate methods.
PyCharm inserts method template when you type
def name(in a class definition.the method template has
selforclssignature. PyCharm detects method type likeclassmethodandstaticmethod.PyCharm inserts
selfon validator methods.Unfortunately, pydantic's validator method is classmethod.
The reason is validator methods don't have
@classmethoddecorator.Also, The PR add inset the text
,. because validators need any argument.Screen Capture