Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config panel #92

Merged
merged 6 commits into from
Dec 15, 2019
Merged

add config panel #92

merged 6 commits into from
Dec 15, 2019

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Dec 2, 2019

The PR adds a config panel and saves configurations on an XML file.

Related issues

#36
#78
#87

Screen Shots

screenshot15

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #92 into master will decrease coverage by 2.21%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage      70.6%   68.39%   -2.22%     
- Complexity       86       89       +3     
============================================
  Files             8       11       +3     
  Lines           609      636      +27     
  Branches        212      215       +3     
============================================
+ Hits            430      435       +5     
- Misses           73       93      +20     
- Partials        106      108       +2
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticConfigurable.kt 0% <0%> (ø) 0 <0> (?)
src/com/koxudaxi/pydantic/PydanticConfigPanel.java 0% <0%> (ø) 0 <0> (?)
src/com/koxudaxi/pydantic/PydanticInspection.kt 69.11% <100%> (+2.45%) 2 <0> (ø) ⬇️
src/com/koxudaxi/pydantic/PydanticConfigService.kt 66.66% <66.66%> (ø) 2 <2> (?)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 68% <75%> (-1.17%) 46 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352aa2d...377cca5. Read the comment docs.

@koxudaxi koxudaxi changed the title [WIP] add config panel add config panel Dec 15, 2019
@koxudaxi koxudaxi merged commit 2457ea7 into master Dec 15, 2019
@koxudaxi koxudaxi deleted the add_config_panel branch December 15, 2019 16:53
@skewty
Copy link

skewty commented Jan 16, 2020

I found this through #36 and was hoping the config panel would allow changes to:

I have an idea. The plugin may have a type support list for famous types.
str, int, datetime, datime, etc...

example: {"date": ["str", "int"]}

Types like pydantic.UUID4 and enum.Enum could be added to that list (if missing) or modified if the user wishes to adjust leniency as in {"int": ["int"]} vs. {"int": ["int", "str", "bytes", "float", "bool"]}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants