Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing --git-builder #119

Closed
brmzkw opened this issue Aug 23, 2023 · 0 comments
Closed

Fix changing --git-builder #119

brmzkw opened this issue Aug 23, 2023 · 0 comments

Comments

@brmzkw
Copy link
Contributor

brmzkw commented Aug 23, 2023

If an application has a buildpack builder, without any settings set, the command koyeb service update theapp/service --git-builder docker doesn't change the builder type.

here we should add:

|| (flags.Lookup("git-builder").Changed && builder == "docker") {

and here we should check if source.GetBuildpack returns a struct with only empty fields.

We also need to update here to add:

		(flags.Lookup("git-builder").Changed && builder == "buildpack") {

and just below, also check if the struct returned by GetDocker() is empty.

@brmzkw brmzkw closed this as completed in 63af7ce Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant