Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppp support #95

Closed
felixonmars opened this issue Sep 20, 2021 · 2 comments · Fixed by #96
Closed

ppp support #95

felixonmars opened this issue Sep 20, 2021 · 2 comments · Fixed by #96

Comments

@felixonmars
Copy link
Contributor

felixonmars commented Sep 20, 2021

Seems like ppp interfaces are not supported now:

$ sniffglue ppp0
Listening on device: "ppp0", verbosity 0/4
Error: Unknown link type: 113 
@kpcyrd
Copy link
Owner

kpcyrd commented Sep 20, 2021

hi!

the link type can be added here: https://github.com/kpcyrd/sniffglue/blob/main/src/link.rs

If ppp emits plain ethernet frames it can be added relatively easily here:

pub fn parse(link: &DataLink, data: &[u8]) -> raw::Raw {
match *link {
DataLink::Ethernet => match parse_eth(data) {
Ok(eth) => eth,
Err(_) => Unknown(data.to_vec()),
},
DataLink::Tun => parse_tun(data),
DataLink::RadioTap => {
Unknown(data.to_vec())
},
}
}

If you have either instructions on how to easily create a ppp device to test with, or a pcap file, that'd be very useful for implementing support. :)

Thanks!

@felixonmars
Copy link
Contributor Author

ppp0.pcap.gz

I'm not familiar with the internals either, hope this pcap file helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants