-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: kpt diff 3way "extra operand" error #1378
Comments
I am going to set it up as triaged for now, but obviously no example makes it hard to do the investigation. If it happens again please see if this is something you can share with the team. Thank you for reporting the bug 🙇 |
I think the diff tool in Cloud Shell doesn't support 3way diffs. It's complaining because it only takes 2 files as arguments, not 3.
|
Looks like Cloud Shell runs Debian 10 buster and has diffutils installed, which comes with diff & diff3. Other linux versions and macs may have different versions of diff installed or even diff3 as diff. |
Hi, your previous comment seems correct.
I did have some success with I'm still exploring other potential options here. For now it may be quickest to install your preferred 3 way diffing tool and provide that tool to kpt. |
is this issue now fixed or is there more? |
I suggest making sure it works in Cloud Shell by default, whether that means a change to kpt or a change to Cloud Shell. |
I agree, I think that is the ideal experience. However, I'm not sure how we'd implement this without introducing a lot of work on our end. Many of the 3 way diffing tools I'm aware of are UI based and |
Hi Karl, right now I think the best option to solve this is to use If your using |
For anyone who finds this later, I suggest using Then use |
Sorry, I don't have a reproducable example on-hand now, but I don't think it should be possible for kpt to send "extra operands" to diff. Seems like a failure for kpt to validate the diff command inputs properly.
The text was updated successfully, but these errors were encountered: