Fix: Ensure Proper Option Passing for JSON Reporter #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
approved these changes
Mar 18, 2024
|
Thanks a lot for the PR, I missed it somehow 🙈 |
|
This just got released as v1.9.0 🎉 Please take it for a spin and thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kræn Hansen,
I hope this finds you well. First and foremost, thank you for the fantastic library!
I'm reaching out because I encountered an issue while using one of the built-in reporters, specifically the JSON reporter. It seems that the options aren't being passed down correctly. After investigating, I noticed a change in the property name from "reporterOption" to "reporterOptions." - mochajs/mocha#4153
To address this issue, I've created a pull request that rectifies the naming inconsistency and ensures proper passing of options to the JSON reporter.
Feel free to review the PR at your earliest convenience. I'm open to any feedback or further adjustments you might suggest.
Looking forward to your thoughts on this!
Best regards,
Georgi