Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add javascript and typescript code in chapter_computational_com… #780

Merged
merged 3 commits into from
Sep 24, 2023
Merged

feat: Add javascript and typescript code in chapter_computational_com… #780

merged 3 commits into from
Sep 24, 2023

Conversation

wenjianmin
Copy link
Contributor

@wenjianmin wenjianmin commented Sep 22, 2023 •
edited
Loading

…plexity

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference codes.
  • I've checked the codes (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

console outputs：

$ node recursion.js 
递归函数的求和结果 res = 15
尾递归函数的求和结果 res = 15
斐波那契数列的第 5 项为 3
递归转化为迭代的求和结果为 res = 15

@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
hello-algo ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2023 3:57pm

krahets
krahets reviewed Sep 22, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code comments are not consistent with other languages. Please address it.

@wenjianmin
Copy link
Contributor Author

The code comments are not consistent with other languages. Please address it.

OK，thanks for reminding！

justin-tse
justin-tse reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@justin-tse justin-tse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wenjianmin Please make sure the function forLoopRecur order are the same with Java or Python

codes/javascript/chapter_computational_complexity/recursion.js Outdated Show resolved Hide resolved
codes/typescript/chapter_computational_complexity/recursion.ts Outdated Show resolved Hide resolved
justin-tse
justin-tse reviewed Sep 24, 2023
View reviewed changes
Copy link
Contributor

@justin-tse justin-tse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenjianmin Thank you for your contribution.

krahets
krahets approved these changes Sep 24, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wenjianmin for the PR and thx Justin for the review!

@krahets krahets merged commit 26bf0c5 into krahets:main Sep 24, 2023
@krahets krahets added the code Code-related label Sep 24, 2023
This was referenced Sep 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-tse justin-tse justin-tse left review comments

@krahets krahets krahets approved these changes

Assignees
No one assigned
Labels
code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenjianmin @justin-tse @krahets