Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl compatible dependencies #107

Open
zeldin opened this issue Mar 1, 2021 · 4 comments
Open

musl compatible dependencies #107

zeldin opened this issue Mar 1, 2021 · 4 comments
Labels
question

Comments

@zeldin
Copy link

zeldin commented Mar 1, 2021

luci_git.bb and uhttpd_git.bb should depend on virtual/crypt rather than directly on libxcrypt. This is necessary in order to be able to build with TCLIBC = "musl", which in turn is needed for compatibility with ipk:s from the SDK or ImageBuilder.
@kraj
Copy link
Owner

kraj commented Mar 2, 2021

I think thats a good improvement. Would you mind cooking a patch ?

@kraj kraj added the bug label Mar 2, 2021
@zeldin
Copy link
Author

zeldin commented Mar 2, 2021

Seems like #106 already fixed this on the dunfell branch. It looks like the commit can just be cherry-picked to master.

@kraj
Copy link
Owner

kraj commented Mar 24, 2021

23f7dfa is on master which fixed it. Are you on latest master ?

@kraj kraj added question and removed bug labels Mar 24, 2021
@zeldin
Copy link
Author

zeldin commented Mar 24, 2021

Actually I'm on dunfell branch now. 😄

That commit looks fine to me, so I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeldin @kraj