Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't jQuery in this Benchmark? #126

Closed
paranoid-android opened this issue Feb 11, 2017 · 4 comments
Closed

Why isn't jQuery in this Benchmark? #126

paranoid-android opened this issue Feb 11, 2017 · 4 comments

Comments

@paranoid-android
Copy link

This benchmark tool is great! I want you to know you've done some great work and I don't want the issue I'm reporting to detract from what's been done.

Still, I'm surprised jQuery hasn't been included in these benchmarks. I can see an argument being made that it's a not a framework like the others that are benchmarked. However, jQuery can create / read / update rows. For that reason, I'm a bit surprised it's not included. I personally think the addition of jQuery 3.1.1 (https://code.jquery.com/jquery-3.1.1.min.js) would be a great addition to this benchmark.

@leeoniya
Copy link
Contributor

I personally think the addition of jQuery 3.1.1 would be a great addition to this benchmark.

Most implementations are submitted as PRs by various authors. You are welcome to submit a jQuery version for inclusion.

@trotyl
Copy link
Contributor

trotyl commented Feb 15, 2017

I can see an argument being made that it's a not a framework like the others that are benchmarked.

The problem here is not about whether something is a framework, but whether something is data-driven.

What actually being tested is how good a library/framework is in finding out what actions to do by checking the data, jQuery is not data-driven, you write what actions to do manually, so you do can test what's the slowdown of jQuery compare to the VanillaJS, but it does not make much sense to compare jQuery with other data-driven framework.

Besides, in most data-driven frameworks, it's still capable for direct DOM manipulation, but that's not what being covered for this benchmark.

@krausest
Copy link
Owner

I must say I'm not particularly interested in adding jQuery. The purpose of this benchmark is to measure the cost of a framework over vanillaJs. And there are many good reasons why one would not use vanillaJs for a real world app. JQuery should be close to vanillaJs and if it's not close, zepto or some low level dom operation mixed with jQuery will be. The existence of vanillaJs should not be interpreted as a recommendation to use it for your next project but just to serve as a baseline (and in some cases it's already behind ;-)

@aminya
Copy link
Contributor

aminya commented Sep 15, 2020

Can we open this again? It is not about "the personal interest or preference", it is about having a reference for comparing the JavaScript DOM libraries. I see everywhere people bash jQuery and say that its performance is a bottleneck.

If this benchmark framework wants to be a reference, it should definitely include jQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants