kroma: upstream op-geth v1.101304.1 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd/evm: improve flags handling This fixes some issues with flags in cmd/evm. The supported flags did not actually show up in help output because they weren't categorized. I'm also adding the VM-related flags to the run command here so they can be given after the subcommand name. So it can be run like this now: ./evm run --code 6001 --debug * cmd/evm: enable all forks by default in run command The default genesis was just empty with no forks at all, which is annoying because contracts will be relying on opcodes introduced in a fork. So this changes the default to have all forks enabled. * core/asm: fix some issues in the assembler This fixes minor bugs in the old assembler: - It is now possible to have comments on the same line as an instruction. - Errors for invalid numbers in the jump instruction are reported better - Line numbers in errors were off by one
This PR makes the tool use the --bootnodes list as the input to devp2p crawl. The flag will take effect if the input/output.json file is missing or empty.
There is no 0.0.3 release of karalabe/usb.
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
Avoid truncating files, if ancients are opened in readonly mode. With this change, we return error instead of trying (and failing) to repair
…(#28163) * trie: remove internal nodes between shortNode and child in path mode * trie: address comments * core/rawdb, trie: address comments * core/rawdb: delete unused func * trie: change comments * trie: add missing tests * trie: fix lint
This allows using the freezer from multiple processes at once in read-only mode. Co-authored-by: Martin Holst Swende <martin@swende.se>
When MatcherSession encounters an error, it attempts to close the session. Closing waits for all goroutines to finish, including the 'distributor'. However, the distributor will not exit until all requests have returned. This patch fixes the issue by delivering the (empty) result to the distributor before calling Close().
This fixes an issue where the --bootnodes flag was overridden by the config file. --------- Co-authored-by: NathanBSC <Nathan.l@nodereal.io> Co-authored-by: Felix Lange <fjl@twurst.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
Adding a space beween function opOrigin() and opcCaller() in instruciton.go. Adding a space beween function opkeccak256() and opAddress() in instruciton.go.
This PR will allow a previously underpriced transaction back in after a timeout of 5 minutes. This will block most transaction spam but allow for transactions to be re-broadcasted on networks with less transaction flow. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
So apparently in the spec the base block parameter of eth_call is optional. I agree that "latest" is a sane default for this that most people would use.
* eth/downloader: remove rollback mechanism in downloader * eth/downloader: remove the tests
core/txpool:fix typos
Fix potential nil pointer dereference panic in superchain overrides
* Set base testnets elasticity * Nit: spelling
Pangssu
requested review from
kangsorang,
0xHansLee,
seolaoh,
jyc228 and
a team
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review. 122 files out of 206 files are above the max files limit of 75. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Pangssu
force-pushed
the
upstream/op-geth/v1.101304.1
branch
from
1dedb4f to
c0350ba
Compare
Pangssu
changed the title
Pangssu
force-pushed
the
upstream/op-geth/v1.101304.1
branch
from
c0350ba to
dc9dbfd
Compare
seolaoh
reviewed
Jan 31, 2024
| // RollupDisableTxPoolGossipFlag | ||
| // RollupEnableTxPoolAdmissionFlag | ||
| // RollupHaltOnIncompatibleProtocolVersionFlag | ||
| // RollupHaltOnIncompatibleProtocolVersionFlag = &cli.StringFlag{ |
There was a problem hiding this comment.
How about enabling rollup halt flag in Kroma also to prevent users not upgrading their nodes cannot properly operate?
seolaoh
reviewed
Jan 31, 2024
| SepoliaGenesisHash = common.HexToHash("0x25a5cc106eea7138acab33231d7160d69cb777ee0c2c553fcddf5138993e6dd9") | ||
| GoerliGenesisHash = common.HexToHash("0xbf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a") | ||
| ) | ||
|
|
||
| const ( | ||
| KromaMainnetChainID = 255 | ||
| KromaSepoliaChainID = 2358 |
There was a problem hiding this comment.
Why don't we add devnet chain ID?
There was a problem hiding this comment.
It should update just before the Canyon hard fork.
Resolve a compilation error caused by the deletion of stack trie owner in op-geth. Related: 442e9a1
Pangssu
force-pushed
the
upstream/op-geth/v1.101304.1
branch
from
dc9dbfd to
5c53d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to upstream to op-geth v1.101304.1.
To make the test work, I reverted the deletion of
SELFDESTRUCTopcode and set it toopUndefinedat the interpreter level.For more information, checkout the op's release.
https://github.com/ethereum-optimism/op-geth/releases/tag/v1.101304.1