-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable canyon upgrade for kroma testnets #65
Conversation
WalkthroughThe recent updates focus on integrating and configuring settings for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (3)
- core/genesis.go (2 hunks)
- params/config.go (1 hunks)
- params/kroma.go (1 hunks)
Additional comments: 5
params/kroma.go (2)
- 13-15: The
UpgradeConfig
struct is correctly defined to hold upgrade times. Ensure that if more parameters are expected in the future, they are added here.- 17-25: The
UpgradeConfigs
map initialization correctly sets the Canyon upgrade times for KromaSepolia and KromaDevnet. Ensure these times align with the project's upgrade schedule.core/genesis.go (2)
- 315-326: The Kroma-specific configuration within
SetupGenesisBlockWithOverride
correctly sets theBedrockBlock
,RegolithTime
,CanyonTime
, andShanghaiTime
. Ensure thatparams.UpgradeConfigs
is correctly populated and that theChainID
is properly managed across different Kroma networks.- 341-348: The handling of
CircuitParams
inChainOverrides
for settingMaxTxPerBlock
andMaxTxPayloadBytesPerBlock
is correct. Verify that these parameters are appropriately used in the rest of the codebase to enforce limits.params/config.go (1)
- 37-37: LGTM. Ensure
KromaDevnetChainID
is integrated correctly where needed.
8e07a93
to
b1379d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- core/genesis.go (2 hunks)
- params/config.go (1 hunks)
- params/kroma.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- core/genesis.go
- params/config.go
- params/kroma.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR with commits that updated the Canyon upgrade activation time for kroma-devnet and kroma-sepolia.
The activation time for kroma-devnet is
1707292800
and for kroma-sepolia is1707897600
At the same time as the Canyon upgrade, the Shanghai upgrade is also activated.
Summary by CodeRabbit
Kroma
chain with specific block and time configurations.Canyon
andShanghai
.Cancun
parameters and circuit configurations.