Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable canyon upgrade for kroma testnets #65

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Pangssu
Copy link
Collaborator

@Pangssu Pangssu commented Feb 6, 2024

Description

This PR with commits that updated the Canyon upgrade activation time for kroma-devnet and kroma-sepolia.
The activation time for kroma-devnet is 1707292800 and for kroma-sepolia is 1707897600
At the same time as the Canyon upgrade, the Shanghai upgrade is also activated.

Summary by CodeRabbit

  • New Features
    • Added support for the Kroma chain with specific block and time configurations.
    • Introduced new network names and upgrade configurations for different Kroma chains.
  • Refactor
    • Adjusted time settings for Canyon and Shanghai.
    • Modified Cancun parameters and circuit configurations.

Copy link

coderabbitai bot commented Feb 6, 2024

Walkthrough

The recent updates focus on integrating and configuring settings for the Kroma blockchain, including specific block and time adjustments. These adjustments also encompass settings for Canyon and Shanghai, alongside modifications for Cancun and circuit parameters. A new chain ID for KromaDevnet has been introduced, as well as network names and upgrade configurations for various Kroma chains.

Changes

File(s) Change Summary
core/genesis.go Adjustments for Kroma chain, including block and time settings for Kroma, Canyon, and Shanghai; modifications for Cancun and circuit parameters.
params/config.go Added KromaDevnetChainID with a value of 7791.
params/kroma.go Introduced network names and upgrade configurations for Kroma chains.

🐇💻✨
In the realm of code, where changes abound,
A rabbit hops forth, leaving marks on the ground.
With each leap and bound, new paths are found,
Celebrating the updates, in bytes and sound.
🌟🚀🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 04e8f66 and 8e07a93.
Files selected for processing (3)
  • core/genesis.go (2 hunks)
  • params/config.go (1 hunks)
  • params/kroma.go (1 hunks)
Additional comments: 5
params/kroma.go (2)
  • 13-15: The UpgradeConfig struct is correctly defined to hold upgrade times. Ensure that if more parameters are expected in the future, they are added here.
  • 17-25: The UpgradeConfigs map initialization correctly sets the Canyon upgrade times for KromaSepolia and KromaDevnet. Ensure these times align with the project's upgrade schedule.
core/genesis.go (2)
  • 315-326: The Kroma-specific configuration within SetupGenesisBlockWithOverride correctly sets the BedrockBlock, RegolithTime, CanyonTime, and ShanghaiTime. Ensure that params.UpgradeConfigs is correctly populated and that the ChainID is properly managed across different Kroma networks.
  • 341-348: The handling of CircuitParams in ChainOverrides for setting MaxTxPerBlock and MaxTxPayloadBytesPerBlock is correct. Verify that these parameters are appropriately used in the rest of the codebase to enforce limits.
params/config.go (1)
  • 37-37: LGTM. Ensure KromaDevnetChainID is integrated correctly where needed.

params/kroma.go Show resolved Hide resolved
@Pangssu Pangssu force-pushed the chore/enable-canyon-testnets branch from 8e07a93 to b1379d6 Compare February 6, 2024 10:11
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 04e8f66 and b1379d6.
Files selected for processing (3)
  • core/genesis.go (2 hunks)
  • params/config.go (1 hunks)
  • params/kroma.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • core/genesis.go
  • params/config.go
  • params/kroma.go

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pangssu Pangssu merged commit e944010 into dev Feb 6, 2024
2 checks passed
@Pangssu Pangssu deleted the chore/enable-canyon-testnets branch February 6, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants