feat: add overhead and l1feescalar proofs to trace #94
Conversation
WalkthroughThe recent update introduces a method named Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- core/vm/logger.go (2 hunks)
- eth/tracers/api_blocktrace.go (1 hunks)
Additional comments not posted (1)
eth/tracers/api_blocktrace.go (1)
265-265: EnsureMaybeAddL1BlockInfoproperly handles errors and null checks.
| func (l *StructLogger) MaybeAddL1BlockInfo(tx *types.Transaction) { | ||
| if contractAddress := *tx.To(); bytes.Equal(contractAddress[:], types.L1BlockAddr[:]) { | ||
| l.storage[contractAddress][types.OverheadSlot] = l.env.StateDB.GetState(contractAddress, types.OverheadSlot) | ||
| l.storage[contractAddress][types.L1FeeScalarsSlot] = l.env.StateDB.GetState(contractAddress, types.L1FeeScalarsSlot) | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider adding a nil check for tx.To() to prevent potential panics.
if tx.To() != nil && bytes.Equal((*tx.To())[:], types.L1BlockAddr[:]) {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| func (l *StructLogger) MaybeAddL1BlockInfo(tx *types.Transaction) { | |
| if contractAddress := *tx.To(); bytes.Equal(contractAddress[:], types.L1BlockAddr[:]) { | |
| l.storage[contractAddress][types.OverheadSlot] = l.env.StateDB.GetState(contractAddress, types.OverheadSlot) | |
| l.storage[contractAddress][types.L1FeeScalarsSlot] = l.env.StateDB.GetState(contractAddress, types.L1FeeScalarsSlot) | |
| } | |
| } | |
| func (l *StructLogger) MaybeAddL1BlockInfo(tx *types.Transaction) { | |
| if tx.To() != nil && bytes.Equal((*tx.To())[:], types.L1BlockAddr[:]) { | |
| l.storage[contractAddress][types.OverheadSlot] = l.env.StateDB.GetState(contractAddress, types.OverheadSlot) | |
| l.storage[contractAddress][types.L1FeeScalarsSlot] = l.env.StateDB.GetState(contractAddress, types.L1FeeScalarsSlot) | |
| } | |
| } |
This reverts commit f5b70a2.
No description provided.