Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate DepositTx and set suggested fee recipient #391

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Pangssu
Copy link
Contributor

@Pangssu Pangssu commented Nov 7, 2024

To reduce code diffs with optimism, separate DepositTx into a OP version and Kroma version, and set suggestedFeeRecipient for payload attributes

This PR cannot use the geth that includes predeploy contract address changes introduced in kroma-network/go-ethereum#125. Therefore, it references commit fd7e2919 from the https://github.com/kroma-network/go-ethereum/commits/pang/separate-deposit-tx branch. The devnet L2 docker image is also built based on this commit.

@Pangssu Pangssu requested a review from a team November 7, 2024 12:08
@Pangssu Pangssu requested a review from a team as a code owner November 7, 2024 12:08
@Pangssu Pangssu removed the request for review from a team November 7, 2024 12:08
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • dev
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from 8285ca1 to 67258f3 Compare November 8, 2024 08:08
@Pangssu Pangssu requested a review from a team as a code owner November 8, 2024 08:08
@seolaoh seolaoh force-pushed the feat/zkvm-fault-proof branch from fa2f566 to a820693 Compare November 8, 2024 09:32
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch 2 times, most recently from 86da0e2 to 3473ad1 Compare November 9, 2024 08:30
op-node/p2p/sync.go Outdated Show resolved Hide resolved
@seolaoh seolaoh changed the base branch from feat/zkvm-fault-proof to feat/state-transition November 29, 2024 04:31
op-node/rollup/derive/attributes.go Outdated Show resolved Hide resolved
op-node/p2p/sync.go Outdated Show resolved Hide resolved
op-e2e/actions/ecotone_fork_test.go Outdated Show resolved Hide resolved
op-e2e/actions/l2_engine_test.go Outdated Show resolved Hide resolved
op-service/eth/types.go Outdated Show resolved Hide resolved
op-e2e/actions/user.go Outdated Show resolved Hide resolved
op-e2e/op_geth_test.go Outdated Show resolved Hide resolved
op-e2e/tx_helper.go Outdated Show resolved Hide resolved
packages/contracts/scripts/go-ffi/differential-testing.go Outdated Show resolved Hide resolved
@Pangssu Pangssu force-pushed the feat/state-transition branch 2 times, most recently from 3b4e360 to a5f5c20 Compare November 29, 2024 07:30
op-node/rollup/derive/attributes.go Show resolved Hide resolved
op-node/rollup/derive/attributes_queue_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/attributes_queue_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/attributes_queue_test.go Outdated Show resolved Hide resolved
@Pangssu Pangssu force-pushed the feat/state-transition branch 4 times, most recently from 1ca5346 to 69ff23f Compare December 2, 2024 07:27
Base automatically changed from feat/state-transition to feat/zkvm-fault-proof December 2, 2024 07:44
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from 3473ad1 to dd9255c Compare December 2, 2024 08:48
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch 2 times, most recently from 367fc32 to a8f5a43 Compare December 5, 2024 06:13
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from a8f5a43 to 2a89698 Compare December 5, 2024 06:20
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from 58e4614 to 504c0e0 Compare December 5, 2024 08:10
op-node/rollup/derive/attributes_test.go Show resolved Hide resolved
op-e2e/op_geth_test.go Show resolved Hide resolved
op-node/rollup/derive/attributes_test.go Outdated Show resolved Hide resolved
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from 504c0e0 to e01d908 Compare December 5, 2024 11:21
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

op-e2e/op_geth.go Outdated Show resolved Hide resolved
op-e2e/op_geth_test.go Outdated Show resolved Hide resolved
op-e2e/op_geth_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/engine_queue_test.go Outdated Show resolved Hide resolved
op-node/p2p/sync.go Outdated Show resolved Hide resolved
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from e01d908 to ea62d36 Compare December 6, 2024 05:41
@Pangssu Pangssu force-pushed the feat/separate-deposit-tx branch from ea62d36 to 0a08515 Compare December 6, 2024 05:42
@Pangssu Pangssu merged commit ebb4431 into feat/zkvm-fault-proof Dec 6, 2024
3 checks passed
@Pangssu Pangssu deleted the feat/separate-deposit-tx branch December 6, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants