-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate DepositTx and set suggested fee recipient #391
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
8285ca1
to
67258f3
Compare
fa2f566
to
a820693
Compare
86da0e2
to
3473ad1
Compare
3b4e360
to
a5f5c20
Compare
1ca5346
to
69ff23f
Compare
3473ad1
to
dd9255c
Compare
367fc32
to
a8f5a43
Compare
a8f5a43
to
2a89698
Compare
58e4614
to
504c0e0
Compare
504c0e0
to
e01d908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e01d908
to
ea62d36
Compare
ea62d36
to
0a08515
Compare
To reduce code diffs with optimism, separate DepositTx into a OP version and Kroma version, and set suggestedFeeRecipient for payload attributes
This PR cannot use the geth that includes predeploy contract address changes introduced in kroma-network/go-ethereum#125. Therefore, it references commit
fd7e2919
from the https://github.com/kroma-network/go-ethereum/commits/pang/separate-deposit-tx branch. The devnet L2 docker image is also built based on this commit.