Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to rotate key pairs? #52

Open
maxmouchet opened this issue Apr 12, 2020 · 3 comments
Open

How to rotate key pairs? #52

maxmouchet opened this issue Apr 12, 2020 · 3 comments
Labels
discussion documentation Improvements or additions to documentation

Comments

@maxmouchet
Copy link
Contributor

  • How should the developer update the public key in a server application?
  • Manual or automatic update?
  • If automatic, it must be secure (e.g. MITM attacks ...)

See #51 and https://stackoverflow.com/questions/39471872/jwt-rs256-is-it-safe-to-fetch-public-key-over-https.

@jrebecchi
Copy link
Member

Tough question indeed! From what I understand: HTTPs solves this question and if using HTTPs is not possible we would have to add a certificate.
It is beyond the scope of this middleware but it is not for the docker image of Krypton. We must force using HTTPS with this Docker image.

@maxmouchet
Copy link
Contributor Author

I don't think we should enable HTTPS in the Docker image, as this would require putting certificates inside the container (doable, but not very convenient).
Usually Docker containers are exposed behind a reverse-proxy which does TLS termination.

But the importance of this should be emphasized in the documentation!

@jrebecchi
Copy link
Member

jrebecchi commented Apr 13, 2020

You make a point! We should emphasize that aspect in the documentation: using HTTPS to ensure the back-end's identity when fetching the public key.

@jrebecchi jrebecchi added the documentation Improvements or additions to documentation label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants