Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license header for gofmt with Go 1.19 #347

Open
ckadner opened this issue Mar 19, 2023 · 0 comments
Open

Update license header for gofmt with Go 1.19 #347

ckadner opened this issue Mar 19, 2023 · 0 comments

Comments

@ckadner
Copy link
Member

ckadner commented Mar 19, 2023

The Go 1.19 Release Notes mention a change to gofmt that causes it to reformat godoc comments.

Because the copyright headers are placed directly above the package declaration, gofmt for 1.19 is interpreting them as godocs and formatting them. (I verified that adding a blank line above the package directive prevents the change.)

The effect that the change to gofmt has on our code will have to be addressed, but I'd prefer that it happens in a separate PR.

Originally posted by @tjohnson31415 in #340 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant