Skip to content

Commit

Permalink
Finish Dec-2019 & July-2020 deprecations (elastic#4065)
Browse files Browse the repository at this point in the history
* Removed logoAPM icon

* Removed euiHeaderNotification class

* Removed 'disabled' color from button components

* Removed deprecated 'withTitle' prop from EuiPopover

* Removed deprecated 'compressed' and 'displayOnly' props from EuiFormRow

* Removed deprecated prop usage from EuiFormRow's tests

* small cleanup

* Removing obsolete test

* linter

* changelog

Co-authored-by: cchaos <caroline.horn@elastic.co>
  • Loading branch information
kshitij86 and cchaos committed Nov 29, 2020
1 parent 85585d4 commit 663c1f6
Show file tree
Hide file tree
Showing 48 changed files with 28 additions and 2,792 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@

- Removed `EuiToggle` and `EuiButtonToggle` in favor of `aria-pressed` ([4056](https://github.com/elastic/eui/pull/4056))
- Updated `legend` and `idSelected` props of `EuiButtonGroup` to be required ([4056](https://github.com/elastic/eui/pull/4056))
- Removed `logoAPM` in favor of `logoObservability` ([4065](https://github.com/elastic/eui/pull/4065))
- Removed `.euiHeaderNotification` CSS class ([4065](https://github.com/elastic/eui/pull/4065))
- Removed `EuiNavDrawer` in favor of `EuiCollapsibleNav` ([4065](https://github.com/elastic/eui/pull/4065))
- Removed `compressed` and `displayOnly` props from `EuiFormRow` in favor of the `display` prop ([4065](https://github.com/elastic/eui/pull/4065))
- Removed `EuiPopover`'s `withTitle` prop ([4065](https://github.com/elastic/eui/pull/4065))

**Theme: Amsterdam**

Expand Down
3 changes: 0 additions & 3 deletions src-docs/src/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ import { ModalExample } from './views/modal/modal_example';

import { MutationObserverExample } from './views/mutation_observer/mutation_observer_example';

import { NavDrawerExample } from './views/nav_drawer/nav_drawer_example';

import { OutsideClickDetectorExample } from './views/outside_click_detector/outside_click_detector_example';

import { OverlayMaskExample } from './views/overlay_mask/overlay_mask_example';
Expand Down Expand Up @@ -335,7 +333,6 @@ const navigation = [
HeaderExample,
HorizontalRuleExample,
ModalExample,
NavDrawerExample,
PageExample,
PanelExample,
PopoverExample,
Expand Down
10 changes: 8 additions & 2 deletions src-docs/src/views/button/button_icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const colors = [
'success',
'warning',
'danger',
'disabled',
];

export default () => (
Expand All @@ -26,9 +25,16 @@ export default () => (
onClick={() => window.alert('Button clicked')}
iconType="arrowRight"
aria-label="Next"
disabled={color === 'disabled' ? true : false}
/>
</EuiFlexItem>
))}
<EuiFlexItem grow={false}>
<EuiButtonIcon
onClick={() => window.alert('Button clicked')}
iconType="arrowRight"
aria-label="Next"
disabled
/>
</EuiFlexItem>
</EuiFlexGroup>
);
1 change: 0 additions & 1 deletion src-docs/src/views/context_menu/context_menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ export default () => {
isOpen={isPopoverOpen}
closePopover={closePopover}
panelPaddingSize="none"
withTitle
anchorPosition="downLeft">
<EuiContextMenu initialPanelId={0} panels={panels} />
</EuiPopover>
Expand Down
2 changes: 0 additions & 2 deletions src-docs/src/views/context_menu/context_menu_with_content.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export default () => {
isOpen={isPopoverOpen}
closePopover={closePopover}
panelPaddingSize="none"
withTitle
anchorPosition="upLeft">
<EuiContextMenu initialPanelId={0} panels={panels} />
</EuiPopover>
Expand All @@ -130,7 +129,6 @@ export default () => {
isOpen={isDynamicPopoverOpen}
closePopover={closeDynamicPopover}
panelPaddingSize="none"
withTitle
anchorPosition="upLeft">
<EuiContextMenu initialPanelId={0} panels={dynamicPanels} />
</EuiPopover>
Expand Down
3 changes: 1 addition & 2 deletions src-docs/src/views/filter_group/filter_group.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ export default () => {
button={button}
isOpen={isPopoverOpen}
closePopover={closePopover}
panelPaddingSize="none"
withTitle>
panelPaddingSize="none">
<div className="euiFilterSelect__note">
<div className="euiFilterSelect__noteContent">
<EuiIcon type="minusInCircle" />
Expand Down
3 changes: 1 addition & 2 deletions src-docs/src/views/filter_group/filter_group_multi.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ export default () => {
button={button}
isOpen={isPopoverOpen}
closePopover={closePopover}
panelPaddingSize="none"
withTitle>
panelPaddingSize="none">
<EuiPopoverTitle>
<EuiFieldSearch />
</EuiPopoverTitle>
Expand Down
Loading

0 comments on commit 663c1f6

Please sign in to comment.