generate a new replay hash when packing replay data

[bemxio]

since some people would probably want to edit replay events
not sure if osu! checks for the replay data hash itself, but it would be good for it to match

[tybug]

hmm…arguably it's sometimes expected behavior that the replay hash doesn’t match. If a user changes both replay_data and replay_hash (for whatever reason), they would probably expect their replay_hash to not be overwritten by us re-computing the hash based on the modified replay_data.

That said, I do think that this is a good think to add as a parameter recalculate_replay_hash in our packing methods, which would update replay_hash based on replay_data as you've described. Not sure if it should default to True or False yet (strictly speaking, True would be a breaking change).

[bemxio]

i think a parameter for that would be good enough
i will try to make a PR today, with the change on

i guess False is good enough to be a default value
if someone would want to be sure that it will work the way they want it to work, they would need to just check the docs