Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_config_set no longer works with generators #2874

Closed
cbay opened this issue Jul 28, 2022 · 3 comments
Closed

send_config_set no longer works with generators #2874

cbay opened this issue Jul 28, 2022 · 3 comments
Labels
bug

Comments

@cbay
Copy link

cbay commented Jul 28, 2022

Starting with bc8fc44, send_config_set no longer works when config_commands is a generator as bypass_commands (which is automatically set by default) will consume the generator, and the rest of the method will have an "empty" config_commands.

That breaks Napalm, for instance.
@ktbyers
Copy link
Owner

ktbyers commented Jul 28, 2022

I am not understanding your reasoning here? How would bypass_commands affect this?

But I will test it.

@ktbyers
Copy link
Owner

ktbyers commented Jul 28, 2022

Nevermind...I see more what you were referring to. Let me look into it some more.

@ktbyers ktbyers added the bug label Jul 28, 2022
@ktbyers ktbyers mentioned this issue Aug 5, 2022
Closed
@ktbyers
Copy link
Owner

ktbyers commented Aug 8, 2022

Fixed here:

#2890

@ktbyers ktbyers closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbay @ktbyers