Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent flowInput validation #725

Closed
tamir321 opened this issue Feb 16, 2020 · 2 comments · Fixed by #732
Closed

inconsistent flowInput validation #725

tamir321 opened this issue Feb 16, 2020 · 2 comments · Fixed by #732

Comments

@tamir321
Copy link

HKube micro-service
Api server

Describe the bug
when executing a stored pipeline that require flowInput object with an empty flowinput object the pipeline starts.
when trying to rerun the same pipeline an error message appears that the flowinput is missing

Expected behavior
should be the same behavior

@nassiharel nassiharel self-assigned this Feb 19, 2020
@nassiharel nassiharel linked a pull request Feb 19, 2020 that will close this issue
@yehiyam yehiyam reopened this Feb 20, 2020
@tamir321
Copy link
Author

tested on version 1.2.40
test was added to pipeline_Test.js

@tamir321
Copy link
Author

Algorithm version Test

File: pipeline_test.js
describe : "validate flowInput exist"

Test description
stored does not have flowInput validate folwInput validation on stored pipeline
raw does not have flowInput validate folwInput validation on raw pipeline
cron does not have flowInput validate folwInput validation on cron pipeline
Trigger does not have flowInput validate folwInput validation on triggerd pipeline
Sub-pipeline does not have flowInput validate folwInput validation on sub-pipeline pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants