Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto add reviewers #15

Merged
merged 2 commits into from
Oct 18, 2022
Merged

chore: auto add reviewers #15

merged 2 commits into from
Oct 18, 2022

Conversation

Abirdcfly
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This pr introduce https://github.com/necojackarc/auto-request-review to arbiter. It can automatically requests review of a pull request based on config.

Which issue(s) this PR fixes:

Update #14

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@Abirdcfly Abirdcfly marked this pull request as draft October 18, 2022 09:08
@Abirdcfly Abirdcfly marked this pull request as ready for review October 18, 2022 09:23
@Abirdcfly Abirdcfly closed this Oct 18, 2022
@Abirdcfly Abirdcfly reopened this Oct 18, 2022
@Abirdcfly
Copy link
Member Author

I have no idea why assign to nkwangleiGIT will cause Error: HttpError: Resource not accessible by integration (log)...

Fix Resource not accessible by integration issue
@nkwangleiGIT
Copy link
Contributor

@Abirdcfly seems the following config can fix this issue:

    permissions:
      pull-requests: write

@nkwangleiGIT
Copy link
Contributor

nkwangleiGIT commented Oct 18, 2022

@Abirdcfly seems the following config can fix this issue:

    permissions:
      pull-requests: write

Following the hints below:
actions/first-interaction#10 (comment)

@nkwangleiGIT
Copy link
Contributor

Still doesn't work, merge it for now and see if the latter PR can be assigned automatically.

@nkwangleiGIT nkwangleiGIT merged commit fec4904 into kube-arbiter:main Oct 18, 2022
nkwangleiGIT added a commit to nkwangleiGIT/arbiter that referenced this pull request Jul 25, 2023
* chore: auto add reviewers

* Add write permissions for auto assign job

Fix Resource not accessible by integration issue

Co-authored-by: Lei <nkwanglei@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants