You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the chunk buffering is inlined into the request_events call.
This makes the function huge, hard to follow, and hard to test.
It would be better if there was a more cleanly separated Reader like struct that dealt with buffering and error handling of un-closed chunks specifically.
Not a big issue, but it makes that code a bit awkward.
The text was updated successfully, but these errors were encountered:
Yeah, I was going to ask about this. Is the response stream of line delimited JSON? Can we use tokio_util::codec::FramedRead with tokio_util::codec::LinesCodec?
Currently the chunk buffering is inlined into the
request_events
call.This makes the function huge, hard to follow, and hard to test.
It would be better if there was a more cleanly separated
Reader
like struct that dealt with buffering and error handling of un-closed chunks specifically.Not a big issue, but it makes that code a bit awkward.
The text was updated successfully, but these errors were encountered: