Finalizer helper #475
Merged
Finalizer helper #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from https://gitlab.com/teozkr/kube-finalizer, with some docs cleanup.
nightkr
commented
Mar 25, 2021
kube-runtime/src/finalizer.rs
Outdated
Comment on lines
82
to
88
| ) -> Result<ReconcilerAction, Error<ApplyFut::Error, CleanupFut::Error>> | ||
| where | ||
| K: Metadata<Ty = ObjectMeta> + Clone + DeserializeOwned + Serialize + Debug, | ||
| ApplyFut: TryFuture<Ok = ReconcilerAction>, | ||
| ApplyFut::Error: StdError + 'static, | ||
| CleanupFut: TryFuture<Ok = ()>, | ||
| CleanupFut::Error: StdError + 'static, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
clux
reviewed
Mar 25, 2021
3 tasks
(Copied and adapted from kube-finalizer)
clux
reviewed
Jul 1, 2021
There was a problem hiding this comment.
I think this is great. It looks like this resolves all my previous concerns about it being hard to read, and it also looks like you've found a really nice way to nest the error types with one error type in your finalizer that nests the users error type that must be the same in apply and cleanup.
I don't think this needs any real changes before merging. Have only left minor readability nits on the example.
clux
approved these changes
Jul 2, 2021
|
released in 0.58 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from https://gitlab.com/teozkr/kube-finalizer, with some docs cleanup.
Fixes #291
Not super happy with the API, but think it would still be useful to get some external feedback..