make Object a more usable #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the same dynamic fashion as DynamicObject, but stricter; - need to conform to Spec/Status model - generally only for deserialisation benefits
also fix missing Debug impl
typemeta not there when listing..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectwasn't really very usable before since it requiredk8s_openapiimpls (so my past use of it had to useRequestdirectly). Now though, withDynamicTypeinResourcetrait, we can avoid that.This implements the same
Resourcestyle impl whenDynamicType=ApiResource.This effectively lets users have a way do typed queries using
Api<Object<P,U>>without having to do a full kube-derive setup, and reusing the erased resource from an existing type (see test example).