Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission controller types and example #484

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Admission controller types and example #484

merged 1 commit into from
Mar 31, 2021

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Mar 31, 2021

Resolves #477

clux
clux reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really nice. Thanks a lot for tackling this! Docs are nice, you've got a great example with warp.

Have only left small nits here and there that I think would make the user experience nicer.

kube/src/api/mod.rs Outdated Show resolved Hide resolved
kube/src/api/dynamic.rs Outdated Show resolved Hide resolved
kube/src/api/admission.rs Outdated Show resolved Hide resolved
kube/src/api/admission.rs Show resolved Hide resolved
examples/admission_controller.rs Outdated Show resolved Hide resolved
kube/src/api/admission.rs Show resolved Hide resolved
examples/admission_controller.rs Show resolved Hide resolved
examples/admission_controller.yaml Outdated Show resolved Hide resolved
examples/admission_controller.yaml Outdated Show resolved Hide resolved
kube/src/api/dynamic.rs Outdated Show resolved Hide resolved
coadler
coadler commented Mar 31, 2021
View reviewed changes
kube/src/api/admission.rs Outdated Show resolved Hide resolved
coadler
coadler commented Mar 31, 2021
View reviewed changes
kube/src/api/admission.rs Outdated Show resolved Hide resolved
clux
clux reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments

kube/src/api/admission.rs Outdated Show resolved Hide resolved
kube/src/api/admission.rs Outdated Show resolved Hide resolved
kube/src/api/admission.rs Show resolved Hide resolved
kube/src/api/admission.rs Outdated Show resolved Hide resolved
kube/src/api/dynamic.rs Outdated Show resolved Hide resolved
examples/admission_controller.rs Show resolved Hide resolved
clux
clux reviewed Mar 31, 2021
View reviewed changes
kube/src/api/admission.rs Outdated Show resolved Hide resolved
clux
clux reviewed Mar 31, 2021
View reviewed changes
kube/src/api/admission.rs Outdated Show resolved Hide resolved
clux
clux approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was incredibly fast for that many iterations.
Thanks a lot for that. A lot easier to keep that in mind-memory for one evening :-)

Ready to merge when you are happy.

@coadler
Copy link
Contributor Author

coadler commented Mar 31, 2021 •
edited
Loading

i'll rebase it back to one commit to remove all the review iterations and i'm good after that! (or just squash how you prefer the commit messages)

@clux clux mentioned this pull request Mar 31, 2021
Closed
3 tasks
@clux clux merged commit fa543b5 into kube-rs:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

admission controller types
2 participants
@coadler @clux