Track the reason for object reconciliation #571
Conversation
| @@ -37,6 +37,7 @@ pub struct FooStatus { | |||
|
|
|||
| fn main() { | |||
| println!("Kind {}", FooCrd::kind(&())); | |||
| #[allow(clippy::blacklisted_name)] | |||
There was a problem hiding this comment.
personally i think we can just hard enable this like it's done in the Makefile tbh; .github/workflows/clippy.yml under the clippy step:
args: -- --allow clippy::blacklisted_nameThere was a problem hiding this comment.
The annoying part there is that it only applies to CI builds. I have Rust-Analyzer set up to watch-run clippy, which wouldn't pick that up.
We could do it with a crate-global #![allow(clippy::blacklisted_name)], but I'm not sure that would be a huge win (it'd still have to be applied separately to each example, kind of going against the whole point).
| jobs.delete("empty-job", &DeleteParams { | ||
| dry_run: true, | ||
| ..DeleteParams::default() | ||
| }) | ||
| .await?; | ||
| jobs.delete("empty-job", &DeleteParams { | ||
| dry_run: false, | ||
| ..DeleteParams::default() | ||
| }) | ||
| .await?; |
There was a problem hiding this comment.
maybe DeleteParams should have builders like ListParams 🤔 . not really a fan of the ..Default for example code for one var change.
| ReconcilerRequestedRetry, | ||
| ErrorPolicyRequestedRetry, | ||
| BulkReconcile, | ||
| Custom { reason: String }, |
There was a problem hiding this comment.
reasons look sensible. but curious about the Custom one, it's not created anywhere, but presumably intentioned as user-facing? can they be returned from the reconciler?
There was a problem hiding this comment.
Yes, if you're using applier then custom trigger functions can inject any reason that it wants to (although it doesn't have to, since we define a ReconcileRequest<K>: From<ObjectRef<K>> that falls back to Unknown).
Maybe Oops, forgot we already know the related object here so there wouldn't be much of a point.Controller::watches should also allow this, actually?
|
this probably closes #457 with all other tasks done. |
|
released in 0.58 :-) |
See #457 (comment), #423
Generally this only tracks the first reason an object to be reconciled.