Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content-Type header to requests with body #627

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add Content-Type header to requests with body #627

merged 1 commit into from
Sep 2, 2021

Conversation

kazk
Copy link
Member

@kazk kazk commented Sep 2, 2021

Closes #626

@kazk kazk mentioned this pull request Sep 2, 2021
Closed
@kazk
Add Content-Type header to requests with body
f804f47 
Signed-off-by: kazk <kazk.dev@gmail.com>
@clux
Copy link
Member

clux commented Sep 2, 2021

That looks good. Works fine with k3d.
We probably need to add it to the few stray places in kube-core subresource.rs that use Request as well.

@clux
Copy link
Member

clux commented Sep 2, 2021

Ah, actually, no. Those don't have body params and should not need content-types - just like the ones you've excluded. I'll merge :-)

@clux clux merged commit b8eb074 into kube-rs:master Sep 2, 2021
@kazk kazk deleted the add-content-type branch September 2, 2021 06:22
@clux
Copy link
Member

clux commented Sep 2, 2021

Released in 0.60.0 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to set content-type for certain cluster types
2 participants
@kazk @clux