Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for stable tooling #707

Open
7 tasks
clux opened this issue Nov 13, 2021 · 0 comments
Open
7 tasks

Tracking issue for stable tooling #707

clux opened this issue Nov 13, 2021 · 0 comments
Labels
docs unclear documentation

Comments

@clux
Copy link
Member

clux commented Nov 13, 2021

As noted in the contributing guide we use nightly ci tooling for rustfmt and rustdoc for a few features not available on stable. This issue lists the nightly features we use in the hope that one day we can just use stable for everything.

This is a developer workflow ergonomics issue, all our published crates work on stable.

rustdoc

  • doc_cfg for RUSTDOCFLAGS="--cfg docsrs"

rustfmt

In descending order of importance:

The last two are ultimately less important if it came down to it. But, unfortunately, all of these have been unstable for ages. Our rustfmt.toml has not changed since it landed.

For now have opened an issue on rustfmt to allow us to at least bail if people accidentally use stable on rustfmt (which re-orders things badly): rust-lang/rustfmt#5022 . But that might also need to graduate (if the prs gets merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs unclear documentation
Projects
None yet
Development

No branches or pull requests

1 participant