Set default resource requests = 1/2 * limits (#653)

Signed-off-by: Tamal Saha <tamal@appscode.com>
kubedb · Nov 12, 2020 · ea20944 · ea20944
1 parent fb8a454
commit ea20944
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/apis/kubedb/v1alpha2/constants.go b/apis/kubedb/v1alpha2/constants.go
@@ -43,8 +43,10 @@ const (
 
 	DBCustomConfigName = "custom-config"
 
-	DefaultCPULimit    = ".25"
-	DefaultMemoryLimit = "512Mi"
+	DefaultCPULimit      = ".250"
+	DefaultMemoryLimit   = "512Mi"
+	DefaultCPURequest    = ".100"
+	DefaultMemoryRequest = "256Mi"
 
 	// =========================== Database key Constants ============================
 	PostgresKey      = ResourceSingularPostgres + "." + kubedb.GroupName

diff --git a/apis/kubedb/v1alpha2/helpers.go b/apis/kubedb/v1alpha2/helpers.go
@@ -81,6 +81,15 @@ func setDefaultResourceLimits(req *core.ResourceRequirements) {
 	if req.Limits == nil {
 		req.Limits = core.ResourceList{}
 	}
+	if req.Requests == nil {
+		req.Requests = core.ResourceList{}
+	}
 	req.Limits[core.ResourceCPU] = fn(core.ResourceCPU, resource.MustParse(DefaultCPULimit))
+	if _, ok := req.Requests[core.ResourceCPU]; !ok {
+		req.Requests[core.ResourceCPU] = resource.MustParse(DefaultCPURequest)
+	}
 	req.Limits[core.ResourceMemory] = fn(core.ResourceMemory, resource.MustParse(DefaultMemoryLimit))
+	if _, ok := req.Requests[core.ResourceMemory]; !ok {
+		req.Requests[core.ResourceMemory] = resource.MustParse(DefaultMemoryRequest)
+	}
 }