Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate crds using kubebuilder instead of manully editing #10

Closed
llhuii opened this issue Feb 18, 2021 · 5 comments
Closed

generate crds using kubebuilder instead of manully editing #10

llhuii opened this issue Feb 18, 2021 · 5 comments

Comments

@llhuii
Copy link

llhuii commented Feb 18, 2021

see the kubebuilder generating-crd.

@khalid-huang
Copy link
Contributor

you mean using kuebuilder to refactor the code of sedna?

@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

since controller-gen doesn't support float(see kubernetes-sigs/controller-tools#245), and we have float64 in incremental-learning job crd, we need to use the option allowDangerousTypes to surround this.
i.e. controller-gen crd:crdVersions=v1,allowDangerousTypes=true ...

@llhuii
Copy link
Author

llhuii commented Feb 19, 2021

you mean using kuebuilder to refactor the code of sedna?

no, just the definitions of CRs(i.e. the directory https://github.com/kubeedge/sedna/tree/main/build/crds/sedna).

@llhuii
Copy link
Author

llhuii commented Feb 22, 2021

since controller-gen doesn't support float(see kubernetes-sigs/controller-tools#245), and we have float64 in incremental-learning job crd, we need to use the option allowDangerousTypes to surround this.
i.e. controller-gen crd:crdVersions=v1,allowDangerousTypes=true ...

just simple look, we could also use resource.Quantity, but it would need more code work.

@llhuii
Copy link
Author

llhuii commented Mar 30, 2021

close this one since #11 cherry pick into #33

@llhuii llhuii closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants