Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Adding compatibility for API supporting HPA #206

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Adding compatibility for API supporting HPA #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfac5b7
Adding compatibility for API supporting HPA
johnugeorge Jan 19, 2023
0cd7653
Fix comments
johnugeorge Jan 19, 2023
e2e1192
Fix code gen
johnugeorge Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/apis/common/v1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion pkg/apis/common/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,13 @@ type ReplicaStatus struct {
// The number of pods which reached phase Failed.
Failed int32 `json:"failed,omitempty"`

// Deprecated: Use Selector instead
LabelSelector *metav1.LabelSelector `json:"labelSelector,omitempty"`

// A label selector is a label query over a set of resources. The result of matchLabels and
// matchExpressions are ANDed. An empty label selector matches all objects. A null
// label selector matches no objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, these are selector, not label selector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

LabelSelector string `json:"labelSelector,omitempty"`
Selector string `json:"selector,omitempty"`
}

// +k8s:openapi-gen=true
Expand Down
8 changes: 7 additions & 1 deletion pkg/apis/common/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.