-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion services folder structure #1144
Labels
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
I agree with your opinion 👍 Furthermore I think we can move |
SGTM |
/assign @andreyvelich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind feature
Currently, we store all suggestion
<algorithm_name>_service.py
files under/pkg/suggestion/v1alpha3
directory.Is there are reason to have structure like that? For example, for Golang Algorithms we have to store service in the same package as other files for the algorithm (See comment: #1131 (comment)).
I think we can add
<algorithm_name>_service.py
files to appropriate algorithm folder.For example,
hyperopt_service.py
to https://github.com/kubeflow/katib/tree/master/pkg/suggestion/v1alpha3/hyperopt.What do you think @gaocegege @johnugeorge @c-bata ?
/cc @richardsliu
The text was updated successfully, but these errors were encountered: