Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion services folder structure #1144

Closed
andreyvelich opened this issue Apr 13, 2020 · 4 comments · Fixed by #1166
Closed

Suggestion services folder structure #1144

andreyvelich opened this issue Apr 13, 2020 · 4 comments · Fixed by #1166
Assignees

Comments

@andreyvelich
Copy link
Member

/kind feature

Currently, we store all suggestion <algorithm_name>_service.py files under /pkg/suggestion/v1alpha3 directory.

Is there are reason to have structure like that? For example, for Golang Algorithms we have to store service in the same package as other files for the algorithm (See comment: #1131 (comment)).

I think we can add <algorithm_name>_service.py files to appropriate algorithm folder.

For example, hyperopt_service.py to https://github.com/kubeflow/katib/tree/master/pkg/suggestion/v1alpha3/hyperopt.
What do you think @gaocegege @johnugeorge @c-bata ?

/cc @richardsliu

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.82

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi jlewi removed the feature label Apr 14, 2020
@c-bata
Copy link
Member

c-bata commented Apr 14, 2020

I agree with your opinion 👍

Furthermore I think we can move /pkg/suggestion/v1alpha3/bayesianoptimization/src to /pkg/suggestion/v1alpha3/bayesianoptimization.

@johnugeorge
Copy link
Member

SGTM

@andreyvelich
Copy link
Member Author

/assign @andreyvelich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants