Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake suggestion interfaces needless #1236

Closed
andreyvelich opened this issue Jun 24, 2020 · 6 comments · Fixed by #1240
Closed

Fake suggestion interfaces needless #1236

andreyvelich opened this issue Jun 24, 2020 · 6 comments · Fixed by #1240

Comments

@andreyvelich
Copy link
Member

/kind question

Do we need fake implementation of Suggestion interface and Suggestion Client interface?

I can see that Suggestion interface was added in: #502 and it is used here: https://github.com/kubeflow/katib/blob/master/pkg/controller.v1beta1/experiment/experiment_controller.go#L85-L87.
Do we have a use-case when it is needed for user?

Suggestion client interface was added in: #742. And it is not used now.

What do you think @gaocegege @johnugeorge ?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.52

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.77

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@gaocegege
Copy link
Member

When will users need it? I cannot figure out such use cases.

@andreyvelich
Copy link
Member Author

@gaocegege In that case, I will delete it.

@andreyvelich
Copy link
Member Author

/assign @andreyvelich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants