-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake suggestion interfaces needless #1236
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
Issue Label Bot is not confident enough to auto-label this issue. |
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
When will users need it? I cannot figure out such use cases. |
@gaocegege In that case, I will delete it. |
/assign @andreyvelich |
/kind question
Do we need fake implementation of
Suggestion
interface andSuggestion Client
interface?I can see that
Suggestion
interface was added in: #502 and it is used here: https://github.com/kubeflow/katib/blob/master/pkg/controller.v1beta1/experiment/experiment_controller.go#L85-L87.Do we have a use-case when it is needed for user?
Suggestion client
interface was added in: #742. And it is not used now.What do you think @gaocegege @johnugeorge ?
The text was updated successfully, but these errors were encountered: