Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return validation errors after all fields are verified #2302

Closed
tenzen-y opened this issue Apr 10, 2024 · 3 comments · Fixed by #2329
Closed

Return validation errors after all fields are verified #2302

tenzen-y opened this issue Apr 10, 2024 · 3 comments · Fixed by #2329
Assignees

Comments

@tenzen-y
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Currently, the katib validator returns errors once the error is found:

return admission.Errored(http.StatusBadRequest, err)

As we discussed here, to improve UX, we should return errors after all fields are verified like the training-operator: https://github.com/kubeflow/training-operator/blob/b5e23d0325005dd0ecae7d41ad6a80ba1459b275/pkg/webhooks/pytorch/pytorchjob_webhook.go#L66-L67

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@ckcd
Copy link
Contributor

ckcd commented Apr 19, 2024

@tenzen-y may I take this issue please?

@tenzen-y
Copy link
Member Author

@tenzen-y may I take this issue please?

Sure, feel free to assign yourself with /assign.

@ckcd
Copy link
Contributor

ckcd commented Apr 21, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants