Add Github Actions CI for charm operators #1407

knkski · 2020-12-04T15:50:05Z

What this PR does / why we need it:

Adds Github Actions CI for charm operators, to ensure that there's no breakages / regressions

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Adds new bundle for CI purposes that points at the latest tags instead of particular revisions.

Release note:

NONE

andreyvelich

Thank you for this contribution @knkski!
I left comments.

andreyvelich · 2020-12-04T21:20:11Z

.github/workflows/test-microk8s.yaml

+      run: |
+        set -eux
+        ./scripts/v1beta1/build.sh -r docker.io/kubeflowkatib -t latest
+        for image in katib-ui katib-controller katib-db-manager; do


Do you need to update other images also?
For example: docker.io/kubeflowkatib/file-metrics-collector ?

I actually took out the usage of ./scripts/v1beta/build.sh, as building all of those images took up too much disk space.

I was thinking about only building the images as they get included in testing, and right now the only test is a simply connectivity test. I'm going to be working on expanding that, but wanted to keep it simple initially.

andreyvelich · 2020-12-04T21:23:22Z

.github/workflows/test-microk8s.yaml

@@ -0,0 +1,83 @@
+name: Charmed Katib


Should you name this file test-microk8s.yml ?
I don't see that this action is running on this PR.

Updated the name of the file to match this name. As far as why it's not showing up, do you have to enable actions in settings or anything? I'm not sure exactly why it's not showing up.

@Bobgy Can you help us with enabling GitHub actions on the Katib repository, please ?
I think it should be pretty straightforward: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository#managing-github-actions-permissions-for-your-repository
/cc @gaocegege @johnugeorge

andreyvelich · 2020-12-04T21:26:50Z

.github/workflows/test-microk8s.yaml

+    - name: Install dependencies
+      run: |
+        set -eux
+        sudo snap install microk8s --classic


Since you are not using any pre-existing GitHub actions (e.g. uses: actions/checkout@v2) to install microk8s, does GitHub actions have any advantages compare to Travis ?
What do you think @gaocegege @johnugeorge @knkski ?

https://github.com/helm/kind-action We can use this action, I think.

Updated it to use the balchua/microk8s-actions@v0.2.1 action. I have a slight preference for github actions due to the UI being better about scrolling through large amounts of output, but can switch to Travis CI if desired.

gaocegege · 2020-12-08T01:55:07Z

ping @andreyvelich

/lgtm

andreyvelich · 2020-12-08T10:56:46Z

/hold
Hold for the GitHub actions activation.
Check this: #1407 (comment).

Builds images locally with `latest` tag, and includes new bundle for testing purposes that sets operator docker images to `latest` as well instead of a particular revision.

knkski · 2020-12-08T17:26:47Z

Pushed up an update that bumped the version of balchua/microk8s-actions from v0.2.1 to v0.2.2

Bobgy · 2020-12-09T17:10:27Z

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository

The page doesn't load atm, I'll take a look later.
A constant reminder, whenever you are blocked for configuring the repo, you should consider whether moving to your own org is a better option for your project.

Bobgy · 2020-12-10T01:45:57Z

I don't think I need to change anything.

By default, GitHub Actions is enabled on all repositories and organizations.

so is katib repo

andreyvelich · 2020-12-10T18:56:57Z

I don't think I need to change anything.

By default, GitHub Actions is enabled on all repositories and organizations.

so is katib repo

Thank you for helping with this!
@Bobgy So In the Katib settings in the Action permissions you are able to see that we allow all actions ?
Like this:

andreyvelich · 2020-12-10T19:02:12Z

@knkski In the meantime, can you try to create PR on your local master branch from you branch on the forked Katib repository ?
Then, we can check if actions will be triggered correctly.
Like I did here: andreyvelich#3.

knkski · 2020-12-10T20:39:26Z

Created knkski#2 to test in the meantime

andreyvelich · 2020-12-10T21:15:59Z

@knkski Thanks!
Btw, @yuzisun how did you enable GitHub actions for the KFServing ?
Have you changed any repo settings before creating the workflow ?

yuzisun · 2020-12-10T21:19:05Z

@knkski Thanks!
Btw, @yuzisun how did you enable GitHub actions for the KFServing ?
Have you changed any repo settings before creating the workflow ?

we added a few secrets in the settings for publishing image and pypi, these are the workflows here we added and they worked.

andreyvelich · 2020-12-10T21:57:01Z

Thanks @yuzisun, it's strange why KFServing and Katib have various GitHub actions policies.

Bobgy · 2020-12-11T06:15:46Z

Yes, it shows all actions are enabled

andreyvelich · 2021-01-04T10:55:25Z

I believe GitHub actions should be activated once we merge this PR.
Check this: kubeflow/training-operator#1196 (review).
/hold cancel
/retest

andreyvelich

/lgtm
/approve

k8s-ci-robot · 2021-01-05T11:54:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, knkski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from johnugeorge and sperlingxx December 4, 2020 15:50

k8s-ci-robot added the size/L label Dec 4, 2020

andreyvelich reviewed Dec 4, 2020

View reviewed changes

knkski force-pushed the add-charm-ci branch from c5a1d0f to 1d737e2 Compare December 7, 2020 22:00

k8s-ci-robot requested a review from gaocegege December 7, 2020 23:41

k8s-ci-robot assigned gaocegege Dec 8, 2020

k8s-ci-robot added the lgtm label Dec 8, 2020

k8s-ci-robot added the do-not-merge/hold label Dec 8, 2020

Add Github Actions CI for charm operators

33343f6

Builds images locally with `latest` tag, and includes new bundle for testing purposes that sets operator docker images to `latest` as well instead of a particular revision.

knkski force-pushed the add-charm-ci branch from 1d737e2 to 33343f6 Compare December 8, 2020 17:25

k8s-ci-robot removed the lgtm label Dec 8, 2020

knkski mentioned this pull request Dec 10, 2020

Add Github Actions CI for charm operators knkski/katib#2

Closed

andreyvelich mentioned this pull request Dec 11, 2020

feat: Add CD using GitHub Actions kubeflow/training-operator#1196

Merged

k8s-ci-robot removed the do-not-merge/hold label Jan 4, 2021

andreyvelich approved these changes Jan 5, 2021

View reviewed changes

k8s-ci-robot assigned andreyvelich Jan 5, 2021

k8s-ci-robot added the lgtm label Jan 5, 2021

k8s-ci-robot added the approved label Jan 5, 2021

k8s-ci-robot merged commit 7901c43 into kubeflow:master Jan 5, 2021

knkski deleted the add-charm-ci branch January 27, 2021 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Github Actions CI for charm operators #1407

Add Github Actions CI for charm operators #1407

knkski commented Dec 4, 2020

andreyvelich left a comment

andreyvelich Dec 4, 2020

knkski Dec 7, 2020

andreyvelich Dec 4, 2020

knkski Dec 7, 2020

andreyvelich Dec 7, 2020

andreyvelich Dec 4, 2020

gaocegege Dec 5, 2020

knkski Dec 7, 2020

gaocegege commented Dec 8, 2020

andreyvelich commented Dec 8, 2020

knkski commented Dec 8, 2020

Bobgy commented Dec 9, 2020 •

edited

Loading

Bobgy commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

knkski commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

yuzisun commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

Bobgy commented Dec 11, 2020

andreyvelich commented Jan 4, 2021

andreyvelich left a comment

k8s-ci-robot commented Jan 5, 2021

Add Github Actions CI for charm operators #1407

Add Github Actions CI for charm operators #1407

Conversation

knkski commented Dec 4, 2020

andreyvelich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaocegege commented Dec 8, 2020

andreyvelich commented Dec 8, 2020

knkski commented Dec 8, 2020

Bobgy commented Dec 9, 2020 • edited Loading

Bobgy commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

knkski commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

yuzisun commented Dec 10, 2020

andreyvelich commented Dec 10, 2020

Bobgy commented Dec 11, 2020

andreyvelich commented Jan 4, 2021

andreyvelich left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 5, 2021

Bobgy commented Dec 9, 2020 •

edited

Loading