Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single character parameters need to have double quote to avoid yaml keyword conflicts #664

Closed
Tomcli opened this issue Jul 8, 2021 · 3 comments · Fixed by #665
Closed
Assignees

Comments

@Tomcli
Copy link
Member

Tomcli commented Jul 8, 2021

I think this is a bug, we should have double quote on single character parameter for n and y to avoid this issue. For now I will lgtm and open another issue for it

Originally posted by @Tomcli in #660 (comment)

@Tomcli
Copy link
Member Author

Tomcli commented Jul 8, 2021

to reproduce this issue, use either n or y as the parameter name or key and the issue will be reproduced. We need to put double quotes on them to avoid these conflicts

@pugangxa
Copy link
Contributor

pugangxa commented Jul 9, 2021

/assign
Strange it works for me with double quotes on. Anyway I will make it clear.

@pugangxa
Copy link
Contributor

pugangxa commented Jul 9, 2021

I found when I run the file conditions_and_loops.py(change n1 back to n) directly then the yaml would be fine. But in test with GENERATE_GOLDEN_YAML being true then it would be error.
Seems it's due to yaml dump/load, see yaml/pyyaml#247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants