-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kfctl.sh delete doesn't check/change kubectl context before issuing delete #1669
Comments
/priority p0 |
Eng:Want PM:Need |
/remove-priority p1 |
/remove-priority p0 |
I'll leave this as P1 for now but it likely won't make it unless someone steps up take this. It might also be easier to implement this as part of turning kfctl.sh into a kfctl go binary. |
Downgrading to P2. Since we plan on switching to a cli #1419 I think it makes sense to invest in that and then fix it in the CLI rather than updating kfctl.sh. |
I don't think kfctl.sh delete verifies that kubectl is pointing at the right cluster before it issues a delete.
We should add a check and verify that we are pointing at the same cluster as the ksonnet app before deleting the namespace.
Here's some code to try to do that in bash.
https://github.com/kubeflow/testing/blob/master/deployment/redeploy_app.sh#L84
The text was updated successfully, but these errors were encountered: